#780 - Add AbstractPolyhedron interface #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mforets
approved these changes
Jan 27, 2019
There was a problem hiding this comment.
Awesome!
I would open a new issue to keep this PR manageable, but I can also add them here.
i suggest to continue in a new issue.
we also have to update the interface hierarchy figure
🔍 Oh yes! I thought about it, but then I forget again. I will do that here and then merge. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #780.
I left out the following generalizations. I would open a new issue to keep this PR manageable, but I can also add them here.
linear_maptoAbstractPolyhedronpolyhedrontoAbstractPolyhedronisemptytoAbstractPolyhedronThere are two optional implementations. The second one would just work. For the first one, we would need the
polyhedronmethod above.